Re: [PATCH v4 0/3] serial: 8250_pnp: Support configurable reg shift property

[Andy Shevchenko]

On Wed, Apr 03, 2024 at 01:01:44PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 03, 2024 at 03:41:27PM +0800, Guanbing Huang wrote:
> > From: Guanbing Huang <albanhuang@xxxxxxxxxxx>
> > 
> > The 16550a serial port based on the ACPI table requires obtaining the
> > reg-shift attribute. In the ACPI scenario, If the reg-shift property
> > is not configured like in DTS, the 16550a serial driver cannot read or
> > write controller registers properly during initialization.
> > 
> > To address the issue of configuring the reg-shift property, the 
> > __uart_read_properties() universal interface is called to implement it.
> > Adaptation of pnp devices is done in the __uart_read_properties() function.
> 
> Thank you!
> 
> I have a few comments, mostly cosmetic except a couple in the last patch.
> Most likely the v4 will be good enough for merging.

Btw, your cover letter is not chained in the same mail thread, be sure you run

	git format-patch -v4 --thread --cover-letter ...

to have proper versioning and cover letter to be chained with the rest.

-- 
With Best Regards,
Andy Shevchenko