Re: [PATCH net-next v3] tg3: Remove residual error handling in tg3_suspend

[Simon Horman]

On Mon, Apr 01, 2024 at 10:14:18PM +0300, Nikita Kiryushin wrote:
> As of now, tg3_power_down_prepare always ends with success, but
> the error handling code from former tg3_set_power_state call is still here.
> 
> This code became unreachable in commit c866b7eac073 ("tg3: Do not use
> legacy PCI power management").
> 
> Remove (now unreachable) error handling code for simplification and change
> tg3_power_down_prepare to a void function as its result is no more checked.
> 
> Signed-off-by: Nikita Kiryushin <kiryushin@xxxxxxxx>
> Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>