Re: [PATCH v1 1/2] gpiolib: Do not mention legacy GPIOF_* in the code

From: Bartosz Golaszewski
Date: Wed Apr 03 2024 - 07:14:59 EST


On Tue, Mar 26, 2024 at 7:12 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> We are going to remove legacy API from kernel, don't mention
> it in the code that does not use it already for a while.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/gpio/gpiolib.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 5589e085ba25..f749ece2d3cd 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -364,7 +364,10 @@ int gpiod_get_direction(struct gpio_desc *desc)
> if (ret < 0)
> return ret;
>
> - /* GPIOF_DIR_IN or other positive, otherwise GPIOF_DIR_OUT */
> + /*
> + * GPIO_LINE_DIRECTION_IN or other positive,
> + * otherwise GPIO_LINE_DIRECTION_OUT.
> + */
> if (ret > 0)
> ret = 1;
>
> --
> 2.43.0.rc1.1.gbec44491f096
>

Applied, thanks!

Bart