Re: [PATCH v5] hid-ft260: Add serial driver

From: Jiri Kosina
Date: Wed Apr 03 2024 - 07:35:13 EST


On Fri, 16 Feb 2024, Christina Quast wrote:

> Adds the serial driver for FT260 USB HID devices, providing direct and
> simplified access to UART functionality without the need for FT260 HID
> report format knowledge.
>
> This chip implements an UART and I2C interface, but only the latter was
> previously supported with a kernel driver. For the UART interface, only
> FTDI example code using hidraw from userspace was available.
>
> This commit adds a serial interface /dev/ttyFTx (FT as in FT260), which
> implements tty serial driver ops, facilitating baudrate configuration,
> data transmission and reception, termios settings.

I don't see a dependency on CONFIG_TTY being added, and I believe it
should be there (even though !CONFIG_TTY configurations are likely
super-rare).

Thanks,

--
Jiri Kosina
SUSE Labs