Re: [PATCH v2] USB: Convert from tasklet to BH workqueue

From: Allen
Date: Wed Apr 03 2024 - 11:40:45 EST


On Wed, Apr 3, 2024 at 8:02 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Apr 03, 2024 at 02:38:52PM +0000, Allen Pais wrote:
> > The only generic interface to execute asynchronously in the BH context is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workqueue
> > behaves similarly to regular workqueues except that the queued work items
> > are executed in the BH context.
> >
> > This patch converts drivers/usb/* from tasklet to BH workqueue.
> >
> > Based on the work done by Tejun Heo <tj@xxxxxxxxxx>
> > Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-610
> >
> > Changes in v2:
> > - Update code comments and commit message.
> > Suggested by Greg K h
> > - Retain local variable name(hcd.c).
> > Suggested by Alan Stern
> >
> > Link to v1:https://lore.kernel.org/all/20240327160314.9982-1
> > -apais@xxxxxxxxxxxxxxxxxxx/T/#m2ec7868fbf102f1551ebe4c92d200848b94af3b1
>
> Why the line-wrap?
>
> And v2 info should all go below the --- line, right?
>
> v3 perhaps?

I missed that bit. I will send out a v3.

Thank you.