Re: Implementing .shutdown method for efa module

From: Jason Gunthorpe
Date: Wed Apr 03 2024 - 11:44:27 EST


On Mon, Apr 01, 2024 at 04:23:32PM +0300, Margolin, Michael wrote:
> Jason
>
> Thanks for your response, efa_remove() is performing reset to the device
> which should stop all DMA from the device.
>
> Except skipping cleanups that are unnecessary for shutdown flow are there
> any other reasons to prefer a separate function for shutdown?

Yes you should skip "cleanups" like removing the IB device and
otherwise as there is a risk of system hang/deadlock in a shutdown
handler context.

Jason