Re: [PATCH RFC net-next 02/10] net: bridge: Always multicast_flood Reports

From: Simon Horman
Date: Wed Apr 03 2024 - 11:52:57 EST


On Mon, Apr 01, 2024 at 08:11:01PM -0400, Joseph Huang wrote:
> Modify the forwarding path so that IGMPv1/v2/MLDv1 Reports are always
> flooded by br_multicast_flood(), regardless of the check done
> by br_multicast_querier_exists().
>
> This patch fixes the problems where shortly after a system boots up,
> the first couple of Reports are not handled properly in that:
>
> 1) The Report from the Host is being flooded (via br_flood) to all
> bridge ports, and
> 2) If the mrouter port's multicast flooding is disabled, the Reports
> received from other hosts will not be forwarded to the Querier.
>
> Fixes: b00589af3b04 ("bridge: disable snooping if there is no querier")
>

There should be no blank line between Fixes and other tags.

If this is a fix, it should be targeted against net,
and likely broken out of this series.

If it is not a fix, then it should not have a Fixes tag.
Rather, you can reference a commit in the commit message text
(not tags) using something like.

Introduced by commit b00589af3b04 ("bridge: disable snooping if there is no querier")

Link: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html

> Signed-off-by: Joseph Huang <Joseph.Huang@xxxxxxxxxx>

..