Re: [PATCH v1 2/4] dt-bindings: arm: fsl: remove reduntant toradex,colibri-imx8x

From: Rob Herring
Date: Wed Apr 03 2024 - 12:57:34 EST


On Tue, Apr 02, 2024 at 04:35:10PM -0300, Hiago De Franco wrote:
> From: Hiago De Franco <hiago.franco@xxxxxxxxxxx>
>
> 'toradex,colibri-imx8x' is already present as a constant value for
> 'i.MX8QP Board with Toradex Colibri iMX8X Modules', so there is no need
> to keep it twice as a enum value for 'i.MX8QXP based Boards'.

If the module can operate on its own, then it would be valid to have
just "toradex,colibri-imx8x". If not, then:

Acked-by: Rob Herring <robh@xxxxxxxxxx>

>
> Signed-off-by: Hiago De Franco <hiago.franco@xxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 0027201e19f8..6fdfa10af43c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1218,7 +1218,6 @@ properties:
> - enum:
> - einfochips,imx8qxp-ai_ml # i.MX8QXP AI_ML Board
> - fsl,imx8qxp-mek # i.MX8QXP MEK Board
> - - toradex,colibri-imx8x # Colibri iMX8X Modules
> - const: fsl,imx8qxp
>
> - description: i.MX8DXL based Boards
> --
> 2.39.2
>