Re: [PATCH] mm/slab_common: Modify mismatched function name

[Andrew Morton]

On Thu, 28 Mar 2024 10:07:11 +0800 Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:

> No functional modification involved.
> 
> mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead.
> 
> ...
>
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags)
>  }
>  
>  /**
> - * krealloc - reallocate memory. The contents will remain unchanged.
> + * krealloc_noprof - reallocate memory. The contents will remain unchanged.
>   * @p: object to reallocate memory for.
>   * @new_size: how many bytes of memory are required.
>   * @flags: the type of memory to allocate.

Well ok, but krealloc_noprof() is just an internal implementation
detail.  I suggest this documentation be moved to the new krealloc()
wrapper site.  Because krealloc() remains the thing which people
actually call.

Presumably the same applies to more of the new _noprof functions.