Re: [PATCH v2] arm64: dts: qcom: msm8916-samsung-fortuna: Add touchscreen

[Nikita Travkin]

Bjorn Andersson писал(а) 03.04.2024 23:49:
> On Tue, Mar 12, 2024 at 07:45:42AM +0000, Raymond Hackley wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
> [..]
>> +&blsp_i2c5 {
>> +	status = "okay";
>> +
>> +	touchscreen: touchscreen@20 {
>> +		compatible = "zinitix,bt541";
>> +		reg = <0x20>;
>> +
>> +		interrupts-extended = <&tlmm 13 IRQ_TYPE_EDGE_FALLING>;
>> +
>> +		touchscreen-size-x = <540>;
>> +		touchscreen-size-y = <960>;
>> +
>> +		vcca-supply = <&reg_vdd_tsp_a>;
>> +		vdd-supply = <&pm8916_l6>;
>> +
>> +		pinctrl-0 = <&tsp_int_default>;
>> +		pinctrl-names = "default";
>> +
>> +		linux,keycodes = <KEY_APPSELECT KEY_BACK>;
> 
> linux,keycodes is not a valid property of zinitix,bt541 according to the
> DeviceTree binding. Is there a binding update for this somewhere?
> 

There is a series for this [1] that Dmitry seems to have no time to pick
up for a long while now, which we carry downstream. Without correct
touchkey definition the touch controller reassigns the tkey lanes to the
screen surface and display calibration breaks a bit, but since we don't
have the changes upstream for now, probably want to drop this line from
the submission so we don't introduce more dtbs_check warnings.

Nikita

[1] https://lore.kernel.org/r/20230801-zinitix-tkey-v4-0-b85526c5a474@xxxxxxx/

> Regards,
> Bjorn