Re: [PATCH 1/1] dt-bindings: media: imx-jpeg: add clocks,clock-names,slot to fix warning

From: Krzysztof Kozlowski
Date: Thu Apr 04 2024 - 02:26:33 EST


On 04/04/2024 05:52, Frank Li wrote:
> Fix below DTB_CHECK warning.
>
> make CHECK_DTBS=y freescale/imx8qxp-mek.dtb
> DTC_CHK arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'slot' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

No, that's not the reason to add properties. Add them if they are valid.



>
> + slot:
> + description: Certain slot number is used.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 3

NAK. Every time.

Fix your DTS instead.

Please read the feedback instead of pushing this stuff for the third time!

https://lore.kernel.org/all/bbb1875b-7980-46aa-80b4-dbaf2a2d5755@xxxxxxxxxx/

Can NXP take responsibility for this piece of code?

Best regards,
Krzysztof