Re: [PATCH 2/7] dt-bindings: clock: qcom: Add DISPCC clocks for SM4450

[Ajit Pandey]

On 3/31/2024 1:47 PM, Krzysztof Kozlowski wrote:
> On 30/03/2024 19:28, Ajit Pandey wrote:
> > Add support for qcom display clock controller bindings
> > for SM4450 platform.
>
> You cannot add support for a binding. Either you add a binding or not.
> Please look at git history for inspiration.
Thanks, will update commit msg in next series
> > Signed-off-by: Ajit Pandey <quic_ajipan@xxxxxxxxxxx>
>
>
> > +
> > +  clocks:
> > +    items:
> > +      - description: Board XO source
> > +      - description: Board active XO source
> > +      - description: Display AHB clock source from GCC
> > +      - description: sleep clock source
> > +      - description: Byte clock from DSI PHY0
> > +      - description: Pixel clock from DSI PHY0
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +  '#power-domain-cells':
> > +    const: 1
>
> No power-domain? This looks incomplete.
>
> Best regards,
> Krzysztof

SM4450 doesn't support MMCX hence power-domain isn't required
--
Thanks, and Regards
Ajit