[PATCH v3] tty: xtensa/iss: Use min() to fix Coccinelle warning

From: Thorsten Blum
Date: Thu Apr 04 2024 - 04:01:21 EST


Inline strlen() and use min() to fix the following Coccinelle/coccicheck
warning reported by minmax.cocci:

WARNING opportunity for min()

Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxxx>
---
Changes in v2:
- Use min() instead of umin() as suggested by Jiri Slaby

Changes in v3:
- Inline strlen() as suggested by Jiri Slaby
---
arch/xtensa/platforms/iss/console.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
index 8896e691c051..abec44b687df 100644
--- a/arch/xtensa/platforms/iss/console.c
+++ b/arch/xtensa/platforms/iss/console.c
@@ -166,10 +166,8 @@ late_initcall(rs_init);

static void iss_console_write(struct console *co, const char *s, unsigned count)
{
- if (s && *s != 0) {
- int len = strlen(s);
- simc_write(1, s, count < len ? count : len);
- }
+ if (s && *s != 0)
+ simc_write(1, s, min(count, strlen(s)));
}

static struct tty_driver* iss_console_device(struct console *c, int *index)
--
2.44.0