Re: [PATCH v2 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log()

[Lukas Wunner]

On Wed, Apr 03, 2024 at 01:02:05PM +0300, Ilpo Järvinen wrote:
> pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix
> Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present.
> 
> Generalize pcie_read_tlp_log() and struct pcie_tlp_log to handle also
> TLP Prefix Log. The layout of relevant registers in AER and DPC
> Capability is not identical but the offsets of TLP Header Log and TLP
                ^^^           ^^^
Somehow this doesn't seem to make sense.  Is the "not" perhaps wrong here?

> Prefix Log vary so the callers must pass the offsets to
> pcie_read_tlp_log().