Re: [PATCH v3 0/6] thermal: More separation between the core and drivers

From: Lukasz Luba
Date: Thu Apr 04 2024 - 07:30:52 EST




On 4/2/24 20:42, Rafael J. Wysocki wrote:
On Tue, Apr 2, 2024 at 9:04 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:

Hi Everyone,

This is an update of

https://lore.kernel.org/linux-pm/4558384.LvFx2qVVIh@kreacher/

and

https://lore.kernel.org/linux-pm/2331888.ElGaqSPkdT@kreacher/

which rebases the first patch on top of 6.9-rc2, adds 3 patches and adjusts
the third patch from v2.

The original description of the first two patches still applies:

Patch [1/2] is based on the observation that the threshold field in struct
thermal_trip really should be core-internal and to make that happen it
introduces a wrapper structure around struct thermal_trip for internal
use in the core.

Patch [2/2] moves the definition of the new structure and the struct
thermal_zone_device one to a local header file in the core to enforce
more separation between the core and drivers.

The patches are not expected to introduce any observable differences in
behavior, so please let me know if you see any of that.

Note that these patches were first sent before the merge window and have not
really changed since then (except for a minor rebase of the first patch in
this series). Moreover, no comments regarding the merit of these patches
have been made shared, so if this continues, I will be considering them as
good to go by the end of this week.

Patch [3/6] is a rewrite of comments regarding trip crossing and threshold
computations.

Patch [4/6] updates the trip crossing detection code to consolidate the
threshold initialization with trip crossing on the way up.

Patch [5/6] ([3/3] in v2) adds a mechanism to sort notifications and debug
calls taking place during one invocation of __thermal_zone_device_update() so
they always go in temperature order.

Patch [6/6] relocates the critical and trip point handling to avoid a
redundant temperature check.

The series applies on top of 6.9-rc2 and I'm planning to create a test
branch containing it.

As promised:

https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/log/?h=thermal-core-testing

Thanks Rafael for the handy branch. I'll play with it today.

Regards,
Lukasz