Re: [PATCH 0/4] dev_printk: add dev_errp_probe() helper

From: Andy Shevchenko
Date: Thu Apr 04 2024 - 08:19:26 EST


+Cc: Andi

On Thu, Apr 04, 2024 at 01:06:22PM +0200, Nuno Sa wrote:
> This series adds a dev_errp_probe() helper. This is similar to
> dev_err_probe() but for cases where an ERR_PTR() is to be returned
> simplifying patterns like:
>
> dev_err_probe(dev, ret, ...);
> return ERR_PTR(ret)

What about ERR_CAST() cases?

> The other three patches are adding users for it. The main motivator for
> this were the changes in the commit ("iio: temperature: ltc2983: convert
> to dev_err_probe()"). Initially I just had a local helper [1] but then
> it was suggested to try a new, common helper. As a result, I looked for
> a couple more users.
>
> I then move into dev_errp_probe() [2] but it was then suggested to separare
> the patch series so we have onde dedicated for the printk helper.
>
> [1]: https://lore.kernel.org/all/20240301-ltc2983-misc-improv-v3-1-c09516ac0efc@xxxxxxxxxx/
> [2]: https://lore.kernel.org/all/20240328-ltc2983-misc-improv-v4-0-0cc428c07cd5@xxxxxxxxxx/

Have you seen mine?

20220214143248.502-1-andriy.shevchenko@xxxxxxxxxxxxxxx

(Note, I'm pretty much fine and thankful that you take care of this)

--
With Best Regards,
Andy Shevchenko