Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

[Jonathan Cameron]

<snip>

> > > @@ -858,7 +910,8 @@ static int __init memory_tier_init(void)
> > >        * For now we can have 4 faster memory tiers with smaller adistance
> > >        * than default DRAM tier.
> > >        */
> > > -     default_dram_type = alloc_memory_type(MEMTIER_ADISTANCE_DRAM);
> > > +     default_dram_type = mt_find_alloc_memory_type(MEMTIER_ADISTANCE_DRAM,
> > > +                                                                     &default_memory_types);  
> >
> > Unusual indenting.  Align with just after (
> >  
> 
> Aligning with "(" will exceed 100 columns. Would that be acceptable?
I think we are talking cross purposes.

	default_dram_type = mt_find_alloc_memory_type(MEMTIER_ADISTANCE_DRAM,
						      &default_memory_types);  

Is what I was suggesting.

> 
> > >       if (IS_ERR(default_dram_type))
> > >               panic("%s() failed to allocate default DRAM tier\n", __func__);
> > >
> > > @@ -868,6 +921,14 @@ static int __init memory_tier_init(void)
> > >        * types assigned.
> > >        */
> > >       for_each_node_state(node, N_MEMORY) {
> > > +             if (!node_state(node, N_CPU))
> > > +                     /*
> > > +                      * Defer memory tier initialization on CPUless numa nodes.
> > > +                      * These will be initialized after firmware and devices are  
> >
> > I think this wraps at just over 80 chars.  Seems silly to wrap so tightly and not
> > quite fit under 80. (this is about 83 chars.
> >  
> 
> I can fix this.
> I have a question. From my patch, this is <80 chars. However,
> in an email, this is >80 chars. Does that mean we need to
> count the number of chars in an email, not in a patch? Or if I
> missed something? like vim configuration or?

3 tabs + 1 space + the text from * (58)
= 24 + 1 + 58 = 83

Advantage of using claws email for kernel stuff is it has a nice per character
ruler at the top of the window.

I wonder if you have a different tab indent size?  The kernel uses 8
characters.  It might explain the few other odd indents if perhaps
you have it at 4 in your editor?

https://www.kernel.org/doc/html/v4.10/process/coding-style.html

Jonathan

> 
> > > +                      * initialized.
> > > +                      */
> > > +                     continue;
> > > +
> > >               memtier = set_node_memory_tier(node);
> > >               if (IS_ERR(memtier))
> > >                       /*  
> >  
> 
>