Re: Re: [PATCH] net: phy: marvell-88q2xxx: add support for Rev B1 and B2

[Gregor Herburger]

Hi Russell,

On Wed, Apr 03, 2024 at 02:59:37PM +0100, Russell King (Oracle) wrote:
> I think a helper would be useful to write these sequences, rather than
> writing the same code several times:

Ok. Will add it to the next version.

> 
> static int mv88q2xxx_write_mmd_vals(struct phy_device *phydev,
> 				    const struct mmd_val *vals, size_t len)
> {
> 	int ret;
> 
> 	for (; len; vals++, len--) {
> 		ret = phy_write_mmd(phydev, vals->devad, vals->regnum,
> 				    vals->val);
> 		if (ret < 0)
> 			return ret;
> 	}
> 
> 	return 0;
> }
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/