Re: [PATCH] platform/x86: quickstart: fix Kconfig selects

From: Armin Wolf
Date: Thu Apr 04 2024 - 10:46:39 EST


Am 04.04.24 um 14:34 schrieb Arnd Bergmann:

From: Arnd Bergmann <arnd@xxxxxxxx>

The new driver Kconfig entry has a typo that causes a link failure
when CONFIG_INPUT_SPARSEKMAP is disabled:

x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify':
quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event'
x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe':
quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup'

Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP.

Fixes: afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index ba88a7f259f1..21a37f1b73ab 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -647,7 +647,7 @@ config ACPI_QUICKSTART
tristate "ACPI Quickstart button driver"
depends on ACPI
depends on INPUT
- select INPUT_SPARSE_KEYMAP
+ select INPUT_SPARSEKMAP
help
This driver adds support for ACPI quickstart button (PNP0C32) devices.
The button emits a manufacturer-specific key value when pressed, so

Reviewed-by: Armin Wolf <W_Armin@xxxxxx>