Re: [PATCH v2 1/2] riscv: thead: Rename T-Head PBMT to MAEE

From: Conor Dooley
Date: Thu Apr 04 2024 - 12:07:31 EST


On Fri, Mar 29, 2024 at 01:14:13PM +0100, Christoph Müllner wrote:
> T-Head's vendor extension to set page attributes has the name
> MAEE (MMU address attribute extension).
> Let's rename it, so it is clear what this referes to.
>
> See also:
> https://github.com/T-head-Semi/thead-extension-spec/blob/master/xtheadmaee.adoc

If there's a resend, make this a Link: tag please.

> Signed-off-by: Christoph Müllner <christoph.muellner@xxxxxxxx>
> ---
> arch/riscv/Kconfig.errata | 8 ++++----
> arch/riscv/errata/thead/errata.c | 8 ++++----
> arch/riscv/include/asm/errata_list.h | 20 ++++++++++----------
> 3 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
> index 910ba8837add..2c24bef7e112 100644
> --- a/arch/riscv/Kconfig.errata
> +++ b/arch/riscv/Kconfig.errata
> @@ -82,14 +82,14 @@ config ERRATA_THEAD
>
> Otherwise, please say "N" here to avoid unnecessary overhead.
>
> -config ERRATA_THEAD_PBMT
> - bool "Apply T-Head memory type errata"
> +config ERRATA_THEAD_MAEE
> + bool "Apply T-Head's MMU address attribute (MAEE)"
> depends on ERRATA_THEAD && 64BIT && MMU
> select RISCV_ALTERNATIVE_EARLY
> default y

Since this defaults to enabled, changing the name should be fair game.

Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature