Re: [PATCH v9 3/4] PCI: brcmstb: Set downstream maximum {no-}snoop LTR values
From: kernel test robot
Date: Thu Apr 04 2024 - 12:49:44 EST
Hi Jim,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 9f8413c4a66f2fb776d3dc3c9ed20bf435eb305e]
url: https://github.com/intel-lab-lkp/linux/commits/Jim-Quinlan/dt-bindings-PCI-brcmstb-Add-property-brcm-clkreq-mode/20240404-054118
base: 9f8413c4a66f2fb776d3dc3c9ed20bf435eb305e
patch link: https://lore.kernel.org/r/20240403213902.26391-4-james.quinlan%40broadcom.com
patch subject: [PATCH v9 3/4] PCI: brcmstb: Set downstream maximum {no-}snoop LTR values
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240405/202404050015.fmF1uXeK-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240405/202404050015.fmF1uXeK-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404050015.fmF1uXeK-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/pci/controller/pcie-brcmstb.c:728:6: warning: no previous prototype for function 'brcm_set_downstream_devs_ltr_max' [-Wmissing-prototypes]
void brcm_set_downstream_devs_ltr_max(struct brcm_pcie *pcie)
^
drivers/pci/controller/pcie-brcmstb.c:728:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void brcm_set_downstream_devs_ltr_max(struct brcm_pcie *pcie)
^
static
1 warning generated.
vim +/brcm_set_downstream_devs_ltr_max +728 drivers/pci/controller/pcie-brcmstb.c
727
> 728 void brcm_set_downstream_devs_ltr_max(struct brcm_pcie *pcie)
729 {
730 struct pci_host_bridge *bridge = pci_host_bridge_from_priv(pcie);
731 u16 ltr_fmt = FIELD_PREP(GENMASK(9, 0), BRCM_LTR_MAX_VALUE)
732 | FIELD_PREP(GENMASK(12, 10), BRCM_LTR_MAX_SCALE)
733 | GENMASK(15, 15);
734
735 if (bridge->native_ltr)
736 pci_walk_bus(bridge->bus, brcm_set_dev_ltr_max, <r_fmt);
737 }
738
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki