Re: [PATCH V4 0/5] mlx5 ConnectX control misc driver
From: Edward Cree
Date: Thu Apr 04 2024 - 15:46:57 EST
On 04/04/2024 19:35, Leon Romanovsky wrote:
> On Thu, Apr 04, 2024 at 07:06:53PM +0100, Edward Cree wrote:
>> Why? What does the kernel get out of it?
>>
>> Maybe *you* need them to be supported, but maybe you should have
>> thought of that earlier in the design process. ("A failure on
>> your part to foresee the eminently foreseeable does not
>> constitute an emergency on mine.")
>> If we let folks bypass our standards with a _fait accompli_, we
>> don't really have standards in the first place.
>
> Sorry, who are "we" and what are "our standards"?
As should be obvious from context, "we" in that sentence referred to
the mainline kernel. And while participants in this thread currently
disagree on what "our standards" are, I hope it is not contentious
that the kernel community *does* have standards as to what code and
design is acceptable for inclusion.
Necessarily, for those standards to be meaningful, there cannot be an
exception for "oh, but we already built our product, it's too late
now", otherwise everyone would just ignore the standards and then
demand to be merged anyway.
That is true regardless of the specific standards in question.
> And, please, please reread the thread, it is not about devlink at all.
Please, please, reread the email to which you are replying; it is
not about devlink at all.
-ed