Re: [PATCH v4 1/5] nvme: authentication error are always non-retryable

[Christoph Hellwig]

On Fri, Apr 05, 2024 at 08:45:11AM +0200, Daniel Wagner wrote:
> > This is still abusing on the wire status code for in-kernel return
> > codes.  Can we please sort this out properly?
> 
> Okay, though I am not really sure how to do it correctly.
> 
> So the current mapping is
> 
>   ret < 0: kernel errors
>   ret = 0: all good
>   ret > 0: wire status incl DNR

Yes.

> In order to split the internal DNR away, we could attach it to the cmd.
> Is this what you had in mind? Or do you mean we should not return
> NVME_SC_AUTH_REQUIRED at all. Instead just a negative value and update
> the error handling on the callers?

The latter.