Re: [PATCH 7/7] arm64: dts: qcom: Add SM8550 Xperia 1 V

From: neil . armstrong
Date: Fri Apr 05 2024 - 03:54:56 EST


On 04/04/2024 21:41, Konrad Dybcio wrote:


On 2/12/24 18:26, Neil Armstrong wrote:
On 12/02/2024 14:10, Konrad Dybcio wrote:
Add support for Sony Xperia 1 V, a.k.a PDX234. This device is a part
of the SoMC SM8550 Yodo platform.


[...]

+/* TODO: Only one SID of PMR735D seems accessible? */


What's reported by the cpuinfo pmic array  ?

PMK8550 2.1
PM8550 2.0
PM8550VS 2.0
PM8550VS 2.0
PM8550VS 2.0
PM8550VE 2.0
PM8550VS 2.0
PM8550B 2.0
PMR735D 2.0
PM8010 1.1
PM8010 1.1

Not sure if there's only one or the other one is secure?


<snip>

With the pcie thing fixed:
Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>

It's gonna be fine with the recent aux clock additions. If you
have no further comments, I'll happily ask for this to be merged ;)

Sure LGTM


Konrad