Re: [PATCH v6 05/16] dt-bindings: net: wireless: describe the ath12k PCI module

From: Krzysztof Kozlowski
Date: Fri Apr 05 2024 - 05:37:50 EST


On 05/04/2024 11:33, Kalle Valo wrote:
> Bartosz Golaszewski <brgl@xxxxxxxx> writes:
>
>> On Mon, Mar 25, 2024 at 3:01 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote:
>>>
>>> Bartosz Golaszewski <brgl@xxxxxxxx> writes:
>>>
>>>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>>>>
>>>> +
>>>> +maintainers:
>>>> + - Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>>>
>>> IMHO it would be better to have just driver maintainers listed here.
>>>
>>
>> Why? What's wrong with having the author of the bindings in the Cc list?
>
> If you want follow the ath12k development and review patches then you
> can join the ath12k list. I'm not fond of having too many maintainers,
> it's not really helping anything and just extra work to periodically
> cleanup the silent maintainers.
>
> I would ask the opposite question: why add you as the maintainer?
> There's not even a single ath12k patch from you, nor I haven't seen you
> doing any patch review or otherwise helping others related to ath12k.
> Don't get me wrong, I value the work you do with this important powerseq
> feature and hopefully we get it into the tree soon. But I don't see
> adding you as a maintainer at this point.

This is not a maintainer of driver. This is maintainer of bindings, so
someone who has hardware, datasheets, knowledge and/or interest in
keeping the bindings accurate.

All your arguments above suggest you talk about the driver. This is not
the point here.

Best regards,
Krzysztof