Re: [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder

From: Kuppuswamy Sathyanarayanan
Date: Fri Apr 05 2024 - 10:45:38 EST



On 4/4/24 11:23 AM, Andy Shevchenko wrote:
> Move x86 related modules (which are solely for x86) to the dedicated
> folder.
> Note, there are more modules, but they are related to tables and
> potentially might be used for other architectures in the future.
> Hence touched only non-table related code.

Except the blacklisted patch Nit, rest looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> In v2:
> - fixed acpi_lpss_init() stub visibility (LKP)
>
> Andy Shevchenko (4):
> ACPI: x86: Introduce a Makefile
> ACPI: x86: Move acpi_cmos_rtc to x86 folder
> ACPI: x86: Move blacklist to x86 folder
> ACPI: x86: Move LPSS to x86 folder
>
> drivers/acpi/Makefile | 7 +------
> drivers/acpi/internal.h | 3 ++-
> drivers/acpi/x86/Makefile | 8 ++++++++
> drivers/acpi/{ => x86}/blacklist.c | 2 +-
> drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} | 2 +-
> drivers/acpi/{acpi_lpss.c => x86/lpss.c} | 2 +-
> 6 files changed, 14 insertions(+), 10 deletions(-)
> create mode 100644 drivers/acpi/x86/Makefile
> rename drivers/acpi/{ => x86}/blacklist.c (99%)
> rename drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} (98%)
> rename drivers/acpi/{acpi_lpss.c => x86/lpss.c} (99%)
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer