Re: [PATCH v2] dt-bindings: omap-mcpdm: Convert to DT schema
From: Mithil
Date: Fri Apr 05 2024 - 10:48:49 EST
So sorry about the 2nd patch being sent as a new mail, here is a new
patch with the changes as suggested
> Please use subject prefixes matching the subsystem
Changed the patch name to match the folder history.
> Is it your full name?
Fixed it, my apologies.
> Filename like compatible.
Fixed.
> Please open existing bindings and look how it is done there.
Changed it, is it fine now?
> Same problem. Drop useless description but provide maxItems.
Removed descriptions for interrupts and hwmods.
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check`
I did run it and it didnt produce any errors henceforth i submitted
the patch.
> Node names should be generic
Changed as said.