Re: [PATCH v2 2/2] Input: edt-ft5x06 - add ft5426

From: Andy Shevchenko
Date: Fri Apr 05 2024 - 13:22:10 EST


On Fri, Apr 5, 2024 at 7:28 PM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
> On Fri, 5 Apr 2024 18:13:45 +0300
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Apr 5, 2024 at 1:20 AM Andreas Kemnade <andreas@kemnadeinfo> wrote:

..

> > > @@ -1484,6 +1484,7 @@ static const struct of_device_id edt_ft5x06_of_match[] = {
> > > { .compatible = "edt,edt-ft5206", .data = &edt_ft5x06_data },
> > > { .compatible = "edt,edt-ft5306", .data = &edt_ft5x06_data },
> > > { .compatible = "edt,edt-ft5406", .data = &edt_ft5x06_data },
> > > + { .compatible = "focaltech,ft5426", .data = &edt_ft5506_data },
> >
> > Why a different vendor prefix?
> > In case you need to use this one, keep the list sorted, currently this
> > splits the edt,* ones.
> >
> How do I know whether to use evervision or edt instead?

Ask DT people, the vendor-prefixes lists both...

> I sorted by the numbers. Looking at datasheets for other controllers I see
> https://www.displayfuture.com/Display/datasheet/controller/FT5x06.pdf
> it only mentions FocalTech Systems Co., Ltd.

But does the driver use that? AFAICS it uses edt. Perhaps it's due to
a business split, not to my knowledge anyway.

> So how the vendor prefixes are derived?

Rob, Krzysztof?

--
With Best Regards,
Andy Shevchenko