Re: [RESEND PATCH v9 2/4] dt-bindings: stm32: update DT bingding for stm32mp25
From: Krzysztof Kozlowski
Date: Fri Apr 05 2024 - 14:22:45 EST
On 05/04/2024 14:54, Gabriel FERNANDEZ wrote:
>
> On 4/5/24 09:12, Krzysztof Kozlowski wrote:
>> On 02/04/2024 14:53, gabriel.fernandez@xxxxxxxxxxx wrote:
>>> From: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
>>>
>>> Now RCC driver use '.index' of clk_parent_data struct to define a parent.
>>> The majority of parents are SCMI clocks, then dt-bindings must be fixed.
>>>
>>> Fixes: b5be49db3d47 ("dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform")
>> And except what Rob said, this does not look as a fix. How ABI break
>> could be a fix and what is even to fix here? Please describe the
>> observable bug, how it manifests itself and what is exactly the fix for
>> that bug.
> As I replied to Rob, there are no RCC STM32MP25 drivers already upstreamed.
>
> However, in my series, the DT binding was merged even though Stephen
> made some
>
> important remarks that needed to be taken into account.
>
> That's why I proposed a fix to update the documentation.
>
> To be sure, how would you like me to proceed?
You can send v3 and get exactly the same questions. Your commit msg must
answer to all such unusual questions. If maintainer asks something that
you need to explain, it is a hint for you that your commit msg is
inadequate.
Best regards,
Krzysztof