Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg()

[Shuah Khan]

On 4/5/24 09:32, Kees Cook wrote:
> On Fri, Apr 05, 2024 at 08:56:31AM -0600, Shuah Khan wrote:
> > On 4/5/24 07:17, Muhammad Usama Anjum wrote:
> > > "Bail out! " is not descriptive. It rather should be: "Failed: " and
> > > then this added prefix doesn't need to be added everywhere. Usually in
> > > the logs, we are searching for "Failed" or "Error" instead of "Bail
> > > out" so it must be replace.
> > >
> > > Remove Error/Failed prefixes from all usages as well.
> > >
> > > Muhammad Usama Anjum (2):
> > >     selftests: Replace "Bail out" with "Error"
> > >     selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages
> > >
> > >    tools/testing/selftests/exec/load_address.c   |   8 +-
> > >    .../testing/selftests/exec/recursion-depth.c  |  10 +-
> > >    tools/testing/selftests/kselftest.h           |   2 +-
> > >    .../selftests/mm/map_fixed_noreplace.c        |  24 +--
> > >    tools/testing/selftests/mm/map_populate.c     |   2 +-
> > >    tools/testing/selftests/mm/mremap_dontunmap.c |   2 +-
> > >    tools/testing/selftests/mm/pagemap_ioctl.c    | 166 +++++++++---------
> > >    .../selftests/mm/split_huge_page_test.c       |   2 +-
> > >    8 files changed, 108 insertions(+), 108 deletions(-)

Usama,

Please generate separate patches for each test (one for exec and
one for mm) when you do this kind of work across tests in the
future. I applied them this time.

> > Andrew, Kees,
> >
> > I will apply these to linux-kselftest next as a series since these
> > changes depend on change to tools/testing/selftests/kselftest.h
> > and need to go together.
> >
> > Are you okay with that?
>
> Sounds good!

Thank you. Applied to linux-kselftest next for Linux 6.10-rc1.

thanks,
-- Shuah