Re: [PATCH] io_uring: Fix io_cqring_wait() not restoring sigmask on get_timespec64() failure

From: Jens Axboe
Date: Sat Apr 06 2024 - 08:57:31 EST


On 4/6/24 5:12 AM, Alexey Izbyshev wrote:
> On 2024-04-06 05:06, Jens Axboe wrote:
>> On 4/5/24 6:55 AM, Alexey Izbyshev wrote:
>>> This bug was introduced in commit 950e79dd7313 ("io_uring: minor
>>> io_cqring_wait() optimization"), which was made in preparation for
>>> adc8682ec690 ("io_uring: Add support for napi_busy_poll"). The latter
>>> got reverted in cb3182167325 ("Revert "io_uring: Add support for
>>> napi_busy_poll""), so simply undo the former as well.
>>
>> Thanks - ironically I had to hand apply this one, as some of the
>> commits you mention above are not in the base you used for the
>> patch...
>
> I used v6.8 as the base, and all three commits mentioned above are
> there. However, the patch indeed doesn't apply to the current tip
> because of post-v6.8 changes, sorry for that!

Not a problem, but it does highlight that this will certainly throw a
reject once stable tries to pick it up. Just something to keep an eye
on.

--
Jens Axboe