Re: [PATCH 0/1] m68k: Handle HAS_IOPORT dependencies

[Michael Schmitz]

Hi Arnd,

Am 07.04.2024 um 03:27 schrieb Arnd Bergmann:
> On Sat, Apr 6, 2024, at 03:14, Michael Schmitz wrote:
> > Am 06.04.2024 um 09:13 schrieb Arnd Bergmann:
> > > On Fri, Apr 5, 2024, at 20:36, Michael Schmitz wrote:
> > > > Am 05.04.2024 um 23:16 schrieb Geert Uytterhoeven:
> > > > The last time I tried to add support for a different PCMCIA ethernet
> > > > adapter to apne.c _without_ adding to the hacks in io_mm.h, I wasn't
> > > > getting anywhere with the netdev crowd. That was ages ago, and I doubt
> > > > their enthusiasm for a rewrite of the 8390 code base to avoid using
> > > > inb() on MMIO architectures will be any better now.
> > >
> > > From what I can see, there is already an abstraction layer in
> > > these drivers that is used by all m68k drivers except apne:
> >
> > As well as ne ... which uses the 8390p.c helper.
>
> Is there any machine using ne.c that doesn't set HAS_IOPORT though?
> Q40 and ATARI_ETHERNEC both have custom inb()/outb(), so
> those are not affected by the change.

Thanks for clarifying - I had been left with the impression that 
inb()/outb() would only be retained for architectures that have not only 
the ISA bus but inb/outb processor instructions.

> > ne.c needs the same treatment as far as I can see, and I could actually
> > test that one (on Atari, not actually on a PC ISA card). I'll see what I
> > can come up with.
>
> ATARI_ROM_ISA turns on HAS_IOPORT, so this one doesn't need any
> immediate changes as a result of Niklas's series. I see now that
> the apne driver doesn't actually need changes either since
> AMIGA_PCMCIA turns on ISA.

Your patch would not actually be too hard to get right as apne only 
needs unconditional address translation (unless we want to take this 
opportunity to introduce 100 Mbit support; I need to dig out my old 
patches for that). But perhaps leave that for later

> I don't think there is an easy way to rework ne.c to avoid
> inb()/outb(), but you could consider splitting the atari
> support out into a separate module the same way as apne.c
> to make it use the atari operations directly.

We used to have atari_ethernec.c for that. AFAIR the netdev maintainers 
asked for us to use ne.c instead. They had suggestions around making IO 
abstractions more flexible for apne.c a while back. I need to revisit that.

> > I might well be missing something else here - as I said, it's been a few
> > years since I worked on the apne driver, and experimented with IO
> > abstractions in that context. The problem has always been making sure
> > drivers shared by different m68k platforms need only be built once and
> > still work on e.g. Q40 and Atari.
>
> Do you know of any other ISA style drivers that are used with the
> amiga pcmcia or the atari rom I/O operations, aside from the 8390
> family? If this is the only one using it, it does sound like this
> could be simplified a lot by just making those two not share the
> object code with the ISA-style ne.c.

No network drivers that I can remember, but the same ROM I/O is used by 
the isp116x-hcd USB driver. That one uses the defines from asm/raw_io.h 
directly though, not inb()/outb().

I don't think any other PCMCIA cards were ever supported on Amiga.

Cheers,

	Michael

>       Arnd