Re: [PATCH v4 2/2] arm64: dts: qcom: sm8550: Add support for Samsung Galaxy Z Fold5

[Alexandru Serdeliuc]

Hi, please excuse my lack of knowledge, I am still trying to figure out 
how to properly send a patch. Hopefully not wasting your time too much.


Here is what was changed, or I should send a v5 and add the 
modifications to cover letter?

- v4

  . removed a spurious new line

  . removed pcie_1_phy_aux_clk as requested

  . removed secondary pcie1 which does not exists on the device

  . changed firmware extension from .mbn to .mdt

  . added missing reserved memory regions required  by firmware to 
properly load


- v3

  . added b4 version 3

  . removed address and size cells in device description


- v2 added both but added an extra v2 in the subject line instead to b4 
subject header, was requested to send the patch again, along with 
following mods:

  . removed whole bootargs line

  . fixed underscores in reserved memory by removing all reserved 
memory regions

  . added missing idetation to  spash_screen remark

  . validated the dts with "dtbs_check"

  . removed all comments at the end of nodes

  . moved status of the node at the end of the node

  . reversed pin control name with control numbers

  . ordered the  nodes alphabetically


- The initial request was split in two patches sent due to the following 
checkpatch warning, was requested to re send them together:

WARNING: DT binding docs and includes should be a separate patch. See: 
Documentation/devicetree/bindings/submitting-patches.rst


On 7/4/24 11:03, Krzysztof Kozlowski wrote:
> On 07/04/2024 07:38, Alexandru Marc Serdeliuc via B4 Relay wrote:
> > From: Alexandru Marc Serdeliuc <serdeliuk@xxxxxxxxx>
> >
> > Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone based on sm8550
> >
> > Currently working features:
> > - Framebuffer
> > - UFS
> > - i2c
> > - Buttons
> >
> > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@xxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/Makefile               |   1 +
> Where is the changelog? This is v4 and nothing (neither here nor in
> cover letter) explained what was happening with this patchset.
>
> Tags were ignored, so maybe comments as well?
>
> Please provide *full* and detailed changelog.
>
> Best regards,
> Krzysztof