Re: [PATCH] wifi: ar5523: enable proper endpoint verification

[Jeff Johnson]

On 4/7/2024 8:05 AM, Nikita Zhandarovich wrote:
[...]
> diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireless/ath/ar5523/ar5523.c
> index 815f8f599f5d..5cac4a6452db 100644
> --- a/drivers/net/wireless/ath/ar5523/ar5523.c
> +++ b/drivers/net/wireless/ath/ar5523/ar5523.c
> @@ -1594,6 +1594,20 @@ static int ar5523_probe(struct usb_interface *intf,
>  	struct ar5523 *ar;
>  	int error = -ENOMEM;
>  
> +	static u8 bulk_ep_addr[] = {

add 'const' qualifier

> +		AR5523_CMD_TX_PIPE | USB_DIR_OUT,
> +		AR5523_DATA_TX_PIPE | USB_DIR_OUT,
> +		AR5523_CMD_RX_PIPE | USB_DIR_IN,
> +		AR5523_DATA_RX_PIPE | USB_DIR_IN,
> +		0};
> +
> +	if (!usb_check_bulk_endpoints(intf, bulk_ep_addr)) {
> +		dev_err(&dev->dev,
> +			"Could not find all expected endpoints\n");
> +		error = -ENODEV;
> +		goto out;
> +	}
> +
>  	/*
>  	 * Load firmware if the device requires it.  This will return
>  	 * -ENXIO on success and we'll get called back afer the usb
>