Re: [PATCH v4 3/5] spi: spi-qpic: Add qpic spi nand driver support

[Alex G.]

On 4/7/24 13:40, Alex G. wrote:
> On 4/7/24 12:48, Alex G. wrote:
> > On 3/8/24 03:17, Md Sadre Alam wrote:
> > > Add qpic spi nand driver support. The spi nand
> > > driver currently supported the below commands.
> > >
> > > -- RESET
> > > -- READ ID
> > > -- SET FEATURE
> > > -- GET FEATURE
> > > -- READ PAGE
> > > -- WRITE PAGE
> > > -- ERASE PAGE
> > >
> > > Co-developed-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > > Co-developed-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> > > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> > > Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx>
> > > ---
> >
> > For the entire series:
> >
> > Tested-by: Alexandru Gagniuc <mr.nuke.me@xxxxxxxxx>
> >
> > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> > > index bc7021da2fe9..63764e943d82 100644
> > > --- a/drivers/spi/Kconfig
> > > +++ b/drivers/spi/Kconfig
> > > @@ -882,6 +882,14 @@ config SPI_QCOM_QSPI
> > >       help
> > >         QSPI(Quad SPI) driver for Qualcomm QSPI controller.
> > > +config SPI_QPIC_SNAND
> > > +    tristate "QPIC SNAND controller"
>
> Also, don't tristate this. It can be set as CONFIG_QPIC_COMMON=m, which 
> will cause the build to fail because you don't have a MODULE_LICENSE().

Please disregard my idiotic suggestion here. I meant to make this 
comment on the previous patch.

> > > +    depends on ARCH_QCOM || COMPILE_TEST
> >
> > Here, it needs to 'select QPIC_COMMON`. Otherwise it can run into 
> > unresolved symbols:
> >
> > : drivers/spi/spi-qpic-snand.o: in function `snandc_set_reg':
> >   drivers/spi/spi-qpic-snand.c:56:(.text+0x484): undefined reference 
> > to `qcom_offset_to_nandc_reg'
> > ...
> >
> > > +    help
> > > +      QPIC_SNAND (QPIC SPI NAND) driver for Qualcomm QPIC controller.
> > > +      QPIC controller supports both parallel nand and serial nand.
> > > +      This config will enable serial nand driver for QPIC controller.
> > > +
> > >   config SPI_QUP
> > >       tristate "Qualcomm SPI controller with QUP interface"
> > >       depends on ARCH_QCOM || COMPILE_TEST
> >
> > Alex
> Alex