Re: [PATCH v3 02/10] perf/alibaba_uncore_drw: Avoid placing cpumask on the stack

From: Shuai Xue
Date: Sun Apr 07 2024 - 20:28:48 EST




On 2024/4/3 23:59, Dawei Li wrote:
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
>
> Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
> the stack.
>
> Suggested-by: Mark Rutland <mark.rutland@xxxxxxx>
> Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx>
> Signed-off-by: Dawei Li <dawei.li@xxxxxxxxxxxx>
> ---

Reviewed-by: Shuai Xue <xueshuai@xxxxxxxxxxxxxxxxx>