Re: [EXT] Re: [PATCH 1/1] dt-bindings: media: imx-jpeg: add clocks,clock-names,slot to fix warning

From: Mirela Rabulea
Date: Sun Apr 07 2024 - 23:15:48 EST


Hi Krzysztof,

On 04.04.2024 09:26, Krzysztof Kozlowski wrote:
Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button


On 04/04/2024 05:52, Frank Li wrote:
Fix below DTB_CHECK warning.

make CHECK_DTBS=y freescale/imx8qxp-mek.dtb
DTC_CHK arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb
arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'slot' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#
No, that's not the reason to add properties. Add them if they are valid.



+ slot:
+ description: Certain slot number is used.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 3
NAK. Every time.

Fix your DTS instead.

Please read the feedback instead of pushing this stuff for the third time!

https://lore.kernel.org/all/bbb1875b-7980-46aa-80b4-dbaf2a2d5755@xxxxxxxxxx/

Can NXP take responsibility for this piece of code?

Thanks for feedback.

For the clocks issue, I looked at the patches sent previously by Alexander Stein and Fabio Estevam, and the current one:

https://lore.kernel.org/linux-devicetree/?q=dfblob%3A3d9d1db3704+dfblob%3A7899e17aff3

As I also said in the past, I think Fabio's patch was more complete, so I took his _v3, I tried to incorporate all the feedback given, and I sent a subsequent _v4, here (bindings & dtb):

https://lore.kernel.org/linux-devicetree/20240408030734.1191069-1-mirela.rabulea@xxxxxxx/


For the slots issue, I will consult with Ming and get back.

Thanks for your patience, and sorry for the inconvenience.


Regards,

Mirela


Best regards,
Krzysztof