Re: [PATCH v2 1/9] MIPS: asm: Move strings to .rodata.str section
From: Philippe Mathieu-Daudé
Date: Mon Apr 08 2024 - 02:48:34 EST
On 26/3/24 21:35, Jiaxun Yang wrote:
Well, they are read only.
Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
---
arch/mips/include/asm/asm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/asm.h b/arch/mips/include/asm/asm.h
index 2e99450f4228..05a158a8920c 100644
--- a/arch/mips/include/asm/asm.h
+++ b/arch/mips/include/asm/asm.h
@@ -94,7 +94,7 @@ symbol: .insn
symbol = value
#define TEXT(msg) \
- .pushsection .data; \
+ .pushsection .rodata.str; \
Nitpicking, \ is now misaligned.
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
8: .asciiz msg; \
.popsection;