Re: [PATCH 1/4] dev_printk: add new dev_errp_probe() helper

[Nuno Sá]

On Sat, 2024-04-06 at 20:35 +0200, Andi Shyti wrote:
> Hi Nuno,
> 
> ...
> 
> > +/* Simple helper for dev_err_probe() when ERR_PTR() is to be returned. */
> > +#define dev_errp_probe(dev, ___err, fmt, ...)	({		\
> > +	ERR_PTR(dev_err_probe(dev, ___err, fmt, ##__VA_ARGS__));	\
> > +})
> 
> I have a whole series adding a set of error oriente printk's. But
> for the time being this looks OK.
> 
> I just don't like the name, the 'p' is an important detail, but
> a bit hidden... how about dev_err_ptr_probe(...)?
> 

Agreed, not a very good name indeed.

- Nuno Sá