Re: [PATCH] watchdog: bd9576: Drop "always-running" property

[Guenter Roeck]

On Mon, Apr 08, 2024 at 01:02:31PM +0300, Matti Vaittinen wrote:
> The always-running (from linux,wdt-gpio.yaml) is abused by the BD9576
> watchdog driver. It's defined meaning is "the watchdog is always running
> and can not be stopped". The BD9576 watchdog driver has implemented it
> as "start watchdog when loading the module and prevent it from being
> stopped".
> 
> Furthermore, the implementation does not set the WDOG_HW_RUNNING when
> enabling the watchdog due to the "always-running" at module loading.
> This will end up resulting a watchdog timeout if the device is not
> opened.
> 
> The culprit was pointed out by Guenter, discussion can be found from
> https://lore.kernel.org/lkml/4fa3a64b-60fb-4e5e-8785-0f14da37eea2@xxxxxxxxxxxx/
> 
> Drop the invalid "always-running" handling.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Fixes: b237bcac557a ("wdt: Support wdt on ROHM BD9576MUF and BD9573MUF")

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter