Re: [PATCH 3/3] perf parse: Allow names to start with digits
From: Dominique Martinet
Date: Mon Apr 08 2024 - 08:50:04 EST
Ian Rogers wrote on Sun, Apr 07, 2024 at 11:32:31AM -0700:
> Try adding PARSER_DEBUG=1 to your command line, I need to do the following:
> ```
> $ make EXTRA_CFLAGS="-Wno-error=redundant-decls" PARSER_DEBUG=1
> ```
Thanks for this hint!
I tried with that earlier and couldn't reproduce either (e.g. it works
with this patch as you observed), looking at my shell history it turns
out I was just sleep-deprived and I had forgotten the '-e' preceding the
probe and didn't grok the error message...
So this patch is ok.
> I think Jiri's e-mail should be jolsa@xxxxxxxxxx.
Ah, right -- I used the mail he actually sent the diff with a couple of
years back, but the address in maintainers is jolsa@xxxxxxxxxx so you're
probably correct that it should be prefered.
I can send a v2 with just this address changed, or whoever picks the
patches up can fix the commit messages for patches 1 & 2, just tell me.
--
Dominique Martinet | Asmadeus