Re: [PATCH] ASoC: soc-card: Fix a reversed if condition

From: Dan Carpenter
Date: Mon Apr 08 2024 - 08:51:13 EST


On Mon, Apr 08, 2024 at 01:43:09PM +0100, Mark Brown wrote:
> On Mon, Apr 08, 2024 at 10:38:02AM +0300, Dan Carpenter wrote:
>
> > ret = snd_soc_register_card(priv->card);
> > - if (!ret)
> > + if (ret)
> > return ret;
> >
> > return 0;
>
> Clearly a better fix here would just be to remove the conditional
> entirely.

Hm... Actually, it should be:

if (ret) {
put_device(priv->card_dev);
return ret;
}

return 0;

Let me resend with that instead.

regards,
dan carpenter