Re: [PATCH v5 0/3] serial: 8250_pnp: Support configurable reg shift property

[Andy Shevchenko]

On Mon, Apr 08, 2024 at 11:36:21AM +0800, Guanbing Huang wrote:
> From: Guanbing Huang <albanhuang@xxxxxxxxxxx>
> 
> The 16550a serial port based on the ACPI table requires obtaining the
> reg-shift attribute. In the ACPI scenario, If the reg-shift property
> is not configured like in DTS, the 16550a serial driver cannot read or
> write controller registers properly during initialization.
> 
> To address the issue of configuring the reg-shift property, the 
> __uart_read_properties() universal interface is called to implement it.
> Adaptation of PNP devices is done in the __uart_read_properties() function.

Seems okay to me now,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko