Re: [PATCH v1] ACPI: Declare acpi_blacklisted() only if CONFIG_X86 is enabled

From: Kuppuswamy Sathyanarayanan
Date: Mon Apr 08 2024 - 11:43:11 EST


On Mon, Apr 8, 2024 at 7:53 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Sat, Apr 06, 2024 at 11:33:41PM -0700, Kuppuswamy Sathyanarayanan wrote:
> > The function acpi_blacklisted() is defined only when CONFIG_X86 is
> > enabled. So to keep it consistent, protect its declaration with
> > CONFIG_X86.
>
> ...
>
> > extern char acpi_video_backlight_string[];
> > extern long acpi_is_video_device(acpi_handle handle);
> > +#ifdef CONFIG_X86
> > extern int acpi_blacklisted(void);
> > +#endif
> > extern void acpi_osi_setup(char *str);
> > extern bool acpi_osi_is_win8(void);
>
> IIRC there is already similar ifdeffery, can we just move the declaration
> there?

There is none for CONFIG_X86. We only have some combinations or
derived config checks like below:

#if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH)
#ifdef CONFIG_X86_IO_APIC

>
> --
> With Best Regards,
> Andy Shevchenko
>
>