Re: [RFC PATCH v3 2/9] cgroup/pids: Separate semantics of pids.events related to pids.max

From: Tejun Heo
Date: Mon Apr 08 2024 - 13:56:00 EST


Hello,

On Fri, Apr 05, 2024 at 07:05:41PM +0200, Michal Koutný wrote:
> Currently, when pids.max limit is breached in the hierarchy, the event
> is counted and reported in the cgroup where the forking task resides.
>
> This decouples the limit and the notification caused by the limit making
> it hard to detect when the actual limit was effected.
>
> Let's introduce new events:
> max
> The number of times the limit of the cgroup was hit.
>
> max.imposed
> The number of times fork failed in the cgroup because of self
> or ancestor limit.

The whole series make sense to me. I'm not sure about max.imposed field
name. Maybe a name which clearly signfies rejection of forks would be
clearer? Johannes, what do you think?

Thanks.

--
tejun