Re: [PATCH v1 1/6] x86/resctrl: Move __resctrl_sched_in() out-of-line

From: Peter Newman
Date: Mon Apr 08 2024 - 15:05:48 EST


Hi Reinette,

On Sun, Apr 7, 2024 at 12:21 PM Reinette Chatre
<reinette.chatre@xxxxxxxxx> wrote:
>
> I think this needs more thought. rdt_enable_key is x86 specific now and should not
> be in the fs code. Every architecture will have its own task switch code, with
> __resctrl_sched_in() belonging to x86 and thus not something to be directly called
> from the fs code.

I think we will need to discuss whether __resctrl_sched_in() is really
arch or FS code following the changes in this series. This series
removes the explicit MSR access and James has already provided inline
wrappers for the mon and alloc enable keys[1], so I can only assume
they are architecture-independent in concept.

Thanks!
-Peter

https://lore.kernel.org/r/20240213184438.16675-18-james.morse@xxxxxxx