Re: [PATCH v5 06/22] drivers/perf: riscv: Implement SBI PMU snapshot function

[Atish Patra]

On 4/4/24 05:01, Andrew Jones wrote:
> On Wed, Apr 03, 2024 at 01:04:35AM -0700, Atish Patra wrote:
> ...
> > +static int pmu_sbi_snapshot_disable(void)
> > +{
> > +	struct sbiret ret;
> > +
> > +	ret = sbi_ecall(SBI_EXT_PMU, SBI_EXT_PMU_SNAPSHOT_SET_SHMEM, -1,
> > +			-1, 0, 0, 0, 0);
>
> The "Rename the SBI_STA_SHMEM_DISABLE" patch should come before this
> patch so SBI_SHMEM_DISABLE can be used instead of the -1's here.

Sure. Done.

> Thanks,
> drew