Re: [PATCH v1 12/31] x86/resctrl: Move max_{name,data}_width into resctrl code

From: Reinette Chatre
Date: Mon Apr 08 2024 - 23:19:31 EST


Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> @@ -2595,6 +2601,12 @@ static int schemata_list_add(struct rdt_resource *r, enum resctrl_conf_type type
> if (cl > max_name_width)
> max_name_width = cl;
>
> + /*
> + * Choose a width for the resource data based on the resource that has
> + * widest name and cbm.

Please check series to ensure upper case is used for acronyms.

> + */
> + max_data_width = max(max_data_width, r->data_width);
> +
> INIT_LIST_HEAD(&s->list);
> list_add(&s->list, &resctrl_schema_all);
>

Reinette