Re: [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup failure

From: PJ Waskiewicz
Date: Tue Apr 09 2024 - 00:23:14 EST


On Mon, 2024-04-08 at 14:32 -0700, PJ Waskiewicz wrote:
> >
> > Turns out that straightforward message is aleady a driver message,
> > but
> > it gets skipped in this case. So, I am thinking of cleanup /
> > clarification along the following lines:
> >
> > 1/ Lean on the existing cxl_get_chbs() validation paths to report
> > on
> > errors
> >
> > 2/ Include the device-name rather than the UID since if UID is
> > unreliable it does not help you communicate with your BIOS vendor.
> > I.e.
> > give a breadcrumb for the BIOS engineer to match the AML device
> > name
> > with the CEDT content.
> >
> > 3/ Do not fail driver load on a single host-bridge parsing failure
> >
> > 4/ These are all cxl_acpi driver init events, so consistently use
> > the
> > ACPI0017 device, and the cxl_acpi driver, as the originator of the
> > error
> > message.
> >
> > Would this clarification have saved you time with the debug?

I guess I should have asked: would you like me to pull this patch in
and give it a test on a known broken host? I'm happy to do it.

-PJ