Re: [PATCH v3 1/2] dt-bindings: mailbox: arm,mhuv3: Add bindings

[Krzysztof Kozlowski]

On 04/04/2024 08:23, Cristian Marussi wrote:
> Add bindings for the ARM MHUv3 Mailbox controller.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>

..

> +        mailbox@2aaa0000 {
> +            compatible = "arm,mhuv3";
> +            #mbox-cells = <3>;
> +            reg = <0 0x2aaa0000 0 0x10000>;
> +            clocks = <&clock 0>;
> +            interrupt-names = "combined", "pbx-dbch-xfer-ack-1",
> +                               "ffch-high-tide-0";
> +            interrupts = <0 36 4>, <0 37 4>;
> +        };
> +
> +        mailbox@2ab00000 {
> +            compatible = "arm,mhuv3";
> +            #mbox-cells = <3>;
> +            reg = <0 0x2aab0000 0 0x10000>;
> +            clocks = <&clock 0>;
> +            interrupt-names = "combined", "mbx-dbch-xfer-1", "ffch-low-tide-0";
> +            interrupts = <0 35 4>, <0 38 4>, <0 39 4>;

Use defines for GIC and level flags.

With this fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof